[
https://issues.apache.org/jira/browse/HBASE-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142815#comment-16142815
]
Hadoop QA commented on HBASE-17732:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 24 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
51s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
54s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 44m 33s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 20s{color}
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 55s{color}
| {color:red} hbase-endpoint in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 6s{color}
| {color:red} hbase-examples in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
57s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}151m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Uncallable method
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$5.postEnvCall(RegionCoprocessorHost$RegionEnvironment)
defined in anonymous class At RegionCoprocessorHost.java:anonymous class At
RegionCoprocessorHost.java:[lines 519-520] |
| Failed junit tests | hadoop.hbase.regionserver.TestKeepDeletes |
| | hadoop.hbase.coprocessor.TestCoprocessorConfiguration |
| | hadoop.hbase.filter.TestFilter |
| | hadoop.hbase.io.encoding.TestPrefixTree |
| | hadoop.hbase.master.locking.TestLockManager |
| | hadoop.hbase.coprocessor.TestCoprocessorInterface |
| | hadoop.hbase.regionserver.TestScanWithBloomError |
| | hadoop.hbase.master.balancer.TestRegionLocationFinder |
| | hadoop.hbase.ipc.TestNettyRpcServer |
| | hadoop.hbase.regionserver.TestHRegionFileSystem |
| | hadoop.hbase.regionserver.TestScanner |
| | hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan |
| | hadoop.hbase.regionserver.TestBlocksScanned |
| | hadoop.hbase.regionserver.wal.TestWALActionsListener |
| | hadoop.hbase.regionserver.TestStoreFileRefresherChore |
| | hadoop.hbase.filter.TestMultipleColumnPrefixFilter |
| | hadoop.hbase.filter.TestColumnPrefixFilter |
| | hadoop.hbase.coprocessor.TestRegionObserverStacking |
| | hadoop.hbase.filter.TestFilterFromRegionSide |
| | hadoop.hbase.filter.TestInvocationRecordFilter |
| | hadoop.hbase.regionserver.TestWideScanner |
| | hadoop.hbase.regionserver.TestMinVersions |
| | hadoop.hbase.procedure.TestProcedureManager |
| | hadoop.hbase.regionserver.TestResettingCounters |
| | hadoop.hbase.filter.TestDependentColumnFilter |
| | hadoop.hbase.client.TestIntraRowPagination |
| | hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange |
| | hadoop.hbase.thrift.TestThriftServerCmdLine |
| | hadoop.hbase.thrift.TestThriftServer |
| | hadoop.hbase.thrift2.TestThriftHBaseServiceHandler |
| | hadoop.hbase.thrift.TestThriftHttpServer |
| | hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels |
| | hadoop.hbase.regionserver.TestServerCustomProtocol |
| | hadoop.hbase.client.TestAsyncAggregationClient |
| | hadoop.hbase.coprocessor.TestClassLoading |
| | hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint |
| | hadoop.hbase.client.TestRpcControllerFactory |
| | hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint |
| | hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint |
| | hadoop.hbase.coprocessor.TestRowProcessorEndpoint |
| | hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData |
| | hadoop.hbase.coprocessor.TestCoprocessorEndpoint |
| | hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint |
| | hadoop.hbase.coprocessor.example.TestRefreshHFilesEndpoint |
| | hadoop.hbase.client.example.TestHttpProxyExample |
| | hadoop.hbase.client.example.TestAsyncClientExample |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-17732 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883903/HBASE-17732.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 686763be354d 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f386a9a |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/8332/artifact/patchprocess/new-findbugs-hbase-server.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8332/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8332/artifact/patchprocess/patch-unit-hbase-thrift.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8332/artifact/patchprocess/patch-unit-hbase-endpoint.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8332/artifact/patchprocess/patch-unit-hbase-examples.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8332/testReport/ |
| modules | C: hbase-client hbase-server hbase-thrift hbase-rsgroup
hbase-endpoint hbase-examples U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8332/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Coprocessor Design Improvements
> -------------------------------
>
> Key: HBASE-17732
> URL: https://issues.apache.org/jira/browse/HBASE-17732
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-17732.master.001.patch,
> HBASE-17732.master.002.patch, HBASE-17732.master.003.patch
>
>
> Adding template for coprocessor type to CoprocessorEnvironment will:
> - get rid of 'instanceOf' checks we do in various coprocessor hosts
> - allow us to load only relevant coprocessors in hosts (right now i think
> each host loads all coprocs and it's only during execOperation that it checks
> if the coproc is of correct type ie XXCoprocessorHost will load XXObserver,
> YYObserver, and all others, and in will check in execOperation if coproc is
> of type XXObserver and ignore the rest).
> - allow sharing of a bunch functions/classes which are currently 99%
> duplicate of each other. For eg. CoprocessorOperations,
> CoprocessorOperationWithResult, execOperations().
> Here's a more detailed design doc:
> https://docs.google.com/document/d/1PBEnaqyJeiHvALFswF_yl81-rOpQmZuixCDua-LT9X4/edit
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
