[
https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142936#comment-16142936
]
Chia-Ping Tsai commented on HBASE-3935:
---------------------------------------
{code}
- public int getStorefileIndexSizeMB() {
- return regionLoadPB.getStorefileIndexSizeMB();
+ public long getStorefileIndexSizeKB() {
+ return regionLoadPB.getStorefileIndexSizeKB();
{code}
The RegionLoad is exposed as IA.Public, so we can't remove the APIs without the
Deprecate. The getStorefileIndexSizeMB() should be reserved and deprecated.
{code}
+ return (int) getStorefileIndexSizeKB() / 1024;
{code}
It will be more precise to perform division before type cast.
> HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
> --------------------------------------------------------------------------
>
> Key: HBASE-3935
> URL: https://issues.apache.org/jira/browse/HBASE-3935
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Andy Yang
> Attachments: HBASE-3935.branch-2.v0.patch,
> HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch,
> HBASE-3935.master.v0.patch
>
>
> Related to HBASE-3927, Matt proposed changing
> HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see
> the size of small store file index.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
