[
https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144484#comment-16144484
]
stack commented on HBASE-18577:
-------------------------------
On commit, could beef up description w/ examples of what invariants are being
enforced (e.g. I didn't get it was maven enforcer until I read down -- even
then, it seems like nice new enforcer tricks that are being deployed her
relative to our other uses of enforcer).
<description>Enforces our invariants for our shaded artifacts.</description>
Related, add a 'what this script does' to your fancy
ensure-jars-have-correct-contents.sh trick script: e.g. what it gets from pom
on cmd-line?
Why the sadness?
<!-- parent pom defines these for children. :( :( :( -->
The parent pom can't do it for this sub pom?
Maybe take a look in modules. I think the additions to root pom have mentions
in modules. Could change these to make use of your new addtion?
Looks great.
> shaded client includes several non-relocated third party dependencies
> ---------------------------------------------------------------------
>
> Key: HBASE-18577
> URL: https://issues.apache.org/jira/browse/HBASE-18577
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13
>
> Attachments: HBASE-18577.6.patch, HBASE-18577-branch-1.v6.patch,
> HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch,
> HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, HBASE-18577.WIP.4.patch,
> HBASE-18577.WIP.5.patch, HBASE-18577.WIP-branch-1.2.v5.patch
>
>
> we have some unexpected unrelocated third party dependencies in our shaded
> artifacts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
