[ 
https://issues.apache.org/jira/browse/HBASE-18461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148461#comment-16148461
 ] 

Yechao Chen edited comment on HBASE-18461 at 8/31/17 5:24 AM:
--------------------------------------------------------------

  "Yechao Chen Any other special characters we should add to your sed replace? "

This patch was commited by [~andrewcheng], I give a  ping, want someone notice 
this.
may be  character " sholud be replaced ,
but window7 and CentOS  can't use a string contains  " as a username
so in my opinion ,replace \ shoule be worked


was (Author: chenyechao):
_     Yechao Chen Any other special characters we should add to your sed 
replace? _

This patch was commited by [~andrewcheng], I give a  ping, want someone notice 
this.
may be  character " sholud be replaced ,
but window7 and CentOS  can't use a string contains  " as a username
so in my opinion ,replace \ shoule be worked

> Build broken If the username contains a backslash
> -------------------------------------------------
>
>                 Key: HBASE-18461
>                 URL: https://issues.apache.org/jira/browse/HBASE-18461
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Guangxu Cheng
>            Assignee: Guangxu Cheng
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.0-alpha-3
>
>         Attachments: HBASE-18461-master-v1.patch, HBASE-18461-master-v2.patch
>
>
> The character '\' is a special character and needs to be escaped when used as 
> part of a String.
> If the name contains '\', we need to escape it,otherwise the generated file 
> Version.java failed to compile.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to