[
https://issues.apache.org/jira/browse/HBASE-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148791#comment-16148791
]
Ashish Singhi commented on HBASE-18721:
---------------------------------------
OK, thanks.
I see you have removed few APIs from public audience classes like CellUtil,
Bytes, ByteBufferUtils... CellUtil class APIs which you removed seems ok to me
but I'm not sure of other classes. Please check them once or better deprecate
them in 2.0 and remove them in 3.0.
{code}
public static final int DEFAULT_ZOOKEPER_MAX_CLIENT_CNXNS = 1000;
{code}
Why have you changed the default value ? In hbase-deafult.xml it is still 300,
need to change there also if changed here.
{code}
@Deprecated // unused. see HBASE-13636. remove this in 3.0
{code}
Can we deprecate them in branch-2 version patch and remove them from master
version patch ?
> Cleanup unused configs and private declaration
> ----------------------------------------------
>
> Key: HBASE-18721
> URL: https://issues.apache.org/jira/browse/HBASE-18721
> Project: HBase
> Issue Type: Sub-task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Minor
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18721.v0.patch
>
>
> Some patches cause the unused configs and private declaration.
> --
> *Remove the useless codes*
> HBASE-17471
> HRegion#HREGION_MVCC_PRE_ASSIGN
> HRegion#DEFAULT_HREGION_MVCC_PRE_ASSIGN
> HBASE-13194
> NamespaceAuditor#NS_AUDITOR_INIT_TIMEOUT
> NamespaceAuditor#DEFAULT_NS_AUDITOR_INIT_TIMEOUT
> HBASE-16812
> HRegionServer#REGION_LOCK_AWAIT_TIME_SEC
> HRegionServer#DEFAULT_REGION_LOCK_AWAIT_TIME_SEC
> HBASE-14614
> DisableTableProcedure#MarkRegionOfflineOpResult
> HBASE-17001
> QuotaSnapshotStore#ViolationState
> HBASE-9949
> StoreScanner#StoreScannerCompactionRace
> HBASE-2840
> DeleteTracker#DeleteCompare
> HBASE-13387
> ByteBufferUtils#lessThanUnsignedLong
> HBASE-17877
> ByteBufferUtils#lessThanUnsignedInt
> ByteBufferUtils#lessThanUnsignedShort
> HBASE-13954
> CellComparator#RowComparator
> HBASE-17001
> QuotaSnapshotStore#ViolationState
> HBASE-17877
> Bytes#lessThanUnsignedLong
> Bytes#lessThanUnsignedInt
> Bytes#lessThanUnsignedShort
> HBASE-18516
> RegionOpeningState
> ResponseConverter#getRegionOpeningState
> ResponseConverter#getRegionOpeningStateList
> HBASE-17277
> BufferedMutatorImpl#HBASE_BUFFEREDMUTATOR_CLASSNAME_KEY
> HBASE-2692
> HConstants#Modify
> HBASE-15158
> CellUtil.EMPTY_TAGS_ITR
> --
> *Deprecate the useless codes exposed as Public*
> HBASE-3065
> HConstants#ZOOKEEPER_RECOVERABLE_WAITTIME
> HConstants#DEFAULT_ZOOKEPER_RECOVERABLE_WAITIME
> HBASE-13636
> HConstants#CLUSTER_IS_DISTRIBUTED
> HBASE-7460
> HConstants#HBASECLIENT_IMPL
> HBASE-12054
> HConstants#LIB_DIR
> HBASE-2692
> HConstants#WEEK_IN_SECONDS
> HBASE-3789
> HConstants#HBCK_CODE_NAME
> HBASE-10569
> HConstants#MASTER_HANDLER_COUNT
> HConstants#DEFAULT_MASTER_HANLDER_COUNT
> HBASE-13616
> HConstants#LOG_REPLAY_WAIT_REGION_TIMEOUT
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
