[ 
https://issues.apache.org/jira/browse/HBASE-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-18699:
------------------------------
    Attachment: HBASE-18699.patch

Let's see the pre commit result first.

Copied the code of {{LoadIncrementalHFiles}} to {{o.a.h.h.tool}}, and also 
copied the UTs to the same package under {{hbase-server/src/test/java}}. 
Changed the Category of the UTs from {{MapReduceTests}} to {{MiscTests. Did 
some simple refactoring to remove warnings. The only changes to the public API 
is the run method. I have split the old
{code}
public Map<LoadQueueItem, ByteBuffer> run(String dirPath, Map<byte[], 
List<Path>> map,
      TableName tableName) throws IOException
{code}
to two methods
{code}
public Map<LoadQueueItem, ByteBuffer> run(String hfofDir, TableName tableName)
      throws IOException
public Map<LoadQueueItem, ByteBuffer> run(Map<byte[], List<Path>> family2Files,
      TableName tableName)
{code}
as {{dirPath}} and {{map}} will never be presented together.

For the old {{LoadIncrementalHFiles}}, marked it as deprecated. Cleaned up all 
the external reference to it. Moved the UTs from {{hbase-mapreduce}} to 
{{hbase-server}}. And also moved 
{{HadoopSecurityEnabledUserProviderForTesting}} back to {{hbase-server}}.



> Copy LoadIncrementalHFiles to another package and mark the old one as 
> deprecated
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-18699
>                 URL: https://issues.apache.org/jira/browse/HBASE-18699
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 3.0.0, 2.0.0-alpha-3
>
>         Attachments: HBASE-18699.patch
>
>
> LoadIncrementalHFiles does not depend on map reduce.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to