[
https://issues.apache.org/jira/browse/HBASE-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150776#comment-16150776
]
Ted Yu commented on HBASE-18652:
--------------------------------
Looks good overall.
{code}
+ if (GLOBAL_L1_CACHE_INSTANCE != null)
+ return GLOBAL_L1_CACHE_INSTANCE.getStats();
{code}
Either wrap the return in curly braces or move it to the same line as if.
> Expose individual cache stats in a CombinedCache through JMX
> ------------------------------------------------------------
>
> Key: HBASE-18652
> URL: https://issues.apache.org/jira/browse/HBASE-18652
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Biju Nair
> Assignee: Biju Nair
> Attachments: HBASE-18652.PATCH, HBASE-18652-WIP.PATCH
>
>
> With offHeap cache being used to store data blocks and on-heap for index and
> bloom filters, exposing the stats from the individual caches through JMX will
> help understand the cache usage trend. Currently the combined cache stats is
> available through JMX which may not provide insight into the individual cache
> usage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
