[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151718#comment-16151718
]
Hadoop QA commented on HBASE-18743:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
42s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}108m 46s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}172m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
| | org.apache.hadoop.hbase.coprocessor.TestHTableWrapper |
| | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
| | org.apache.hadoop.hbase.wal.TestWALFiltering |
| | org.apache.hadoop.hbase.coprocessor.TestCoprocessorMetrics |
| | org.apache.hadoop.hbase.regionserver.wal.TestWALReplay |
| | org.apache.hadoop.hbase.security.access.TestAccessController2 |
| | org.apache.hadoop.hbase.replication.TestReplicationStateHBaseImpl |
| | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | org.apache.hadoop.hbase.wal.TestWALSplitCompressed |
| | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.constraint.TestConstraint |
| | org.apache.hadoop.hbase.mob.compactions.TestPartitionedMobCompactor |
| | org.apache.hadoop.hbase.quotas.TestRegionSizeUse |
| | org.apache.hadoop.hbase.coprocessor.TestMasterObserver |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort |
| | org.apache.hadoop.hbase.regionserver.TestCompactSplitThread |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort |
| | org.apache.hadoop.hbase.ipc.TestRpcClientLeaks |
| | org.apache.hadoop.hbase.coprocessor.TestWALObserver |
| | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush |
| | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput |
| | org.apache.hadoop.hbase.coprocessor.TestIncrementTimeRange |
| | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss |
| | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotas |
| | org.apache.hadoop.hbase.mob.compactions.TestMobCompactor |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors
|
| |
org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController
|
| | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
|
| | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner |
| | org.apache.hadoop.hbase.security.access.TestAccessControlFilter |
| | org.apache.hadoop.hbase.backup.TestHFileArchiving |
| | org.apache.hadoop.hbase.TestNamespace |
| | org.apache.hadoop.hbase.io.encoding.TestChangingEncoding |
| | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks |
| | org.apache.hadoop.hbase.TestMovedRegionsCleaner |
| | org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots |
| | org.apache.hadoop.hbase.regionserver.TestRecoveredEdits |
| | org.apache.hadoop.hbase.TestInfoServers |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
|
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
| | org.apache.hadoop.hbase.security.access.TestCellACLs |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports |
| | org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.replication.TestReplicationTableBase |
| | org.apache.hadoop.hbase.TestIOFencing |
| | org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk |
| | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite |
| | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
|
| | org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions |
| | org.apache.hadoop.hbase.fs.TestBlockReorder |
| |
org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
|
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed |
| | org.apache.hadoop.hbase.io.hfile.TestHFileBlock |
| | org.apache.hadoop.hbase.snapshot.TestRegionSnapshotTask |
| | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication |
| |
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove |
| | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy |
| | org.apache.hadoop.hbase.wal.TestWALFactory |
| | org.apache.hadoop.hbase.security.access.TestZKPermissionWatcher |
| | org.apache.hadoop.hbase.quotas.TestQuotaAdmin |
| |
org.apache.hadoop.hbase.replication.regionserver.TestTableBasedReplicationSourceManagerImpl
|
| | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad |
| | org.apache.hadoop.hbase.replication.TestMasterReplication |
| |
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManagerZkImpl
|
| | org.apache.hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay |
| | org.apache.hadoop.hbase.replication.TestReplicationSource |
| |
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort |
| | org.apache.hadoop.hbase.tool.TestCanaryTool |
| | org.apache.hadoop.hbase.io.TestFileLink |
| | org.apache.hadoop.hbase.wal.TestWALSplit |
| | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-18743 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12885119/HBASE_18743_v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux e39b625b3b67 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 7c51d3f |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8446/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8446/testReport/ |
| modules | C: hbase-common hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8446/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> HFiles that are in use by a table whitch have the same name and namespace
> with a default table cloned from snapshot may be deleted when that snapshot
> and default table is deleted
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
> Affects Versions: 1.1.12
> Reporter: wenbang
> Priority: Critical
> Attachments: HBASE_18743.patch, HBASE_18743_v1.patch,
> HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
