[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152135#comment-16152135
]
Hadoop QA commented on HBASE-18743:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-18743 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18743 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12885188/HBASE-18743_branch-1_v1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8458/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
> Affects Versions: 1.1.12
> Reporter: wenbang
> Assignee: wenbang
> Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743_branch-1.patch,
> HBASE-18743_branch-1_v1.patch, HBASE_18743.patch, HBASE_18743_v1.patch,
> HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
