[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-15497:
-----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
[~cuijianwei] Thanks for the patch.
Consider using your github email in your patch. Otherwise, the commit won't be
connected to your account in github. I commit the patch with your github email.
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -----------------------------------------------------------------
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.0.0
> Reporter: Jianwei Cui
> Assignee: Jianwei Cui
> Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
