[
https://issues.apache.org/jira/browse/HBASE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185788#comment-13185788
]
[email protected] commented on HBASE-5196:
------------------------------------------------------
bq. On 2012-01-13 19:26:42, Ted Yu wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java,
line 366
bq. > <https://reviews.apache.org/r/3488/diff/1/?file=68852#file68852line366>
bq. >
bq. > I prefer an enum here:
bq. > daughter not missing,
bq. > daughter missing and fixed,
bq. > daughter missing but not fixed
I'd say that if you are interested, look in logs?
I think we should get the basic patch in first. Can do the fancy stuff in
another issue?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3488/#review4364
-----------------------------------------------------------
On 2012-01-13 19:11:36, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3488/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-13 19:11:36)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When the master starts up, this patch tries to scan all offline split
parents and fix up missing daughters as the ServerShutdownHandler does.
bq.
bq.
bq. This addresses bug HBASE-5196.
bq. https://issues.apache.org/jira/browse/HBASE-5196
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java cb2f084
bq.
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
8f4f4b8
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
41f5dff
bq.
bq. Diff: https://reviews.apache.org/r/3488/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I test the fix in my real cluster and it does fix the problem.
bq.
bq. I am working on a unit test now.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Failure in region split after PONR could cause region hole
> ----------------------------------------------------------
>
> Key: HBASE-5196
> URL: https://issues.apache.org/jira/browse/HBASE-5196
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
>
> If region split fails after PONR, it relies on the master ServerShutdown
> handler to fix it. However, if the master doesn't get a chance to fix it.
> There will be a hole in the region chain.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
