[
https://issues.apache.org/jira/browse/HBASE-18720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156326#comment-16156326
]
Ted Yu commented on HBASE-18720:
--------------------------------
After upgrade, this command :
{code}
buck test --no-results-cache core:multi-retry-test
{code}
yields:
{code}
/usr/src/hbase/hbase-native-client/buck-out/gen/core/core#default,static/libcore.a(raw-async-table.cc.o):
In function `folly::Future<std::unique_ptr<hbase::Response,
std::default_delete<hbase::Response> > >::throwIfInvalid() const':
/usr/local/include/folly/futures/Future-inl.h:222: undefined reference to
`folly::throwNoState()'
/usr/local/include/folly/futures/Future-inl.h:222: undefined reference to
`folly::throwNoState()'
/usr/src/hbase/hbase-native-client/buck-out/gen/core/core#default,static/libcore.a(raw-async-table.cc.o):
In function `folly::Promise<folly::Unit>::throwIfFulfilled()':
/usr/local/include/folly/futures/Promise-inl.h:53: undefined reference to
`folly::throwNoState()'
/usr/local/include/folly/futures/Promise-inl.h:56: undefined reference to
`folly::throwPromiseAlreadySatisfied()'
/usr/src/hbase/hbase-native-client/buck-out/gen/core/core#default,static/libcore.a(raw-async-table.cc.o):
In function `folly::Try<std::unique_ptr<hbase::Response,
std::default_delete<hbase::Response> > >::throwIfFailed() const':
/usr/local/include/folly/Try-inl.h:134: undefined reference to
`folly::try_detail::throwUsingUninitializedTry()'
/usr/src/hbase/hbase-native-client/buck-out/gen/core/core#default,static/libcore.a(raw-async-table.cc.o):
In function `folly::Future<std::unique_ptr<hbase::Response,
std::default_delete<hbase::Response> > >::throwIfInvalid() const':
/usr/local/include/folly/futures/Future-inl.h:222: undefined reference to
`folly::throwNoState()'
/usr/local/include/folly/futures/Future-inl.h:222: undefined reference to
`folly::throwNoState()'
/usr/src/hbase/hbase-native-client/buck-out/gen/core/core#default,static/libcore.a(raw-async-table.cc.o):
In function `folly::Promise<bool>::throwIfFulfilled()':
/usr/local/include/folly/futures/Promise-inl.h:53: undefined reference to
`folly::throwNoState()'
/usr/local/include/folly/futures/Promise-inl.h:56: undefined reference to
`folly::throwPromiseAlreadySatisfied()'
{code}
> [C++] Update wangle dependency to pick up the new release with Apache License
> v2
> --------------------------------------------------------------------------------
>
> Key: HBASE-18720
> URL: https://issues.apache.org/jira/browse/HBASE-18720
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Blocker
> Fix For: HBASE-14850
>
> Attachments: hbase-18720-v1.patch
>
>
> Good news that Facebook decided to re-license the wangle library to use
> Apache License v2. This unblocks the eventual merge of branch HBASE-14850
> since there will be no remaining licensing issues with dependencies.
> However, we need to update the wangle dependency version to include the
> commit
> https://github.com/facebook/wangle/commit/5f686dee5753890f37326fcf38c396b7ba8981ee.
> Next weekly release tag for wangle should be sufficient.
> See
> https://github.com/facebook/wangle/issues/105
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)