[
https://issues.apache.org/jira/browse/HBASE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156552#comment-16156552
]
Lijian Shen commented on HBASE-15931:
-------------------------------------
Hi, @Yu Li, the patch has one defect on the LOG print.
LOG.info("#" + id + ", waiting for some tasks to finish. Expected
max=" + max
+ ", tasksInProgress=" + currentInProgress + " hasError=" +
hasError()
+ tableName == null ? "" : ", tableName=" + tableName);
Here need add one bracket for (tableName == null ? "" : ", tableName=" +
tableName), otherwise it will print wrong result because of operator priority,
current the print result is like, no other string logged:
", tableName=table1"
> Add log for long-running tasks in AsyncProcess
> ----------------------------------------------
>
> Key: HBASE-15931
> URL: https://issues.apache.org/jira/browse/HBASE-15931
> Project: HBase
> Issue Type: Improvement
> Components: Operability
> Reporter: Yu Li
> Assignee: Yu Li
> Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.4.0, 0.98.20, 1.1.6, 1.2.3
>
> Attachments: HBASE-15931.patch
>
>
> Currently if there's any long-tail tasks in a multi-action request like
> triggered by {{BufferedMutatorImpl#backgroundFlushCommits}}, we could see
> logging message like below
> {noformat}
> 2016-05-31 09:36:55,461 INFO [Thread-16]
> org.apache.hadoop.hbase.client.AsyncProcess: #28, waiting for some tasks to
> finish. Expected max=0, tasksInProgress=1
> {noformat}
> but there's no way to know detail of this long-tail, such as which
> table/region it's accessing. This JIRA aims at adding such log for easier
> debugging.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
