[ 
https://issues.apache.org/jira/browse/HBASE-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160604#comment-16160604
 ] 

Duo Zhang commented on HBASE-18772:
-----------------------------------

Skimmed. Seems some of the modifications are not necessary. LongAdder is useful 
when write is much more than read. But in your patch, for example, 
BufferedMutatorImpl, the read and write are almost the same for 
currentWriteBufferSize? 

> [JDK8]  Replace AtomicLong with LongAdder
> -----------------------------------------
>
>                 Key: HBASE-18772
>                 URL: https://issues.apache.org/jira/browse/HBASE-18772
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha-2
>            Reporter: Yechao Chen
>            Assignee: Yechao Chen
>            Priority: Trivial
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18772.master.patch
>
>
> RCurrently we use many AtomicLong in HBase Region Code ,such as BucketCache 
> calss realCacheSize,heapSize,blockNumber,accessCount  and HRegion calss  
> compactionNumBytesCompacted etc .
> In JDK8 LongAdder  is faster than AtomicLong ,should use this replace  
> AtomicLong 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to