[ 
https://issues.apache.org/jira/browse/HBASE-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160630#comment-16160630
 ] 

Appy commented on HBASE-18760:
------------------------------

Looks like shaded checks get executed as part of precommit and +1/-1 are being 
added to final summary.
Checked the log "patch-shadedclient.txt". looks good.
Should be good to check-in.
+1

Nit: Maybe change "shaded client" to "shaded jars" or "shaded-check-invariant" 
to make it clear that it doesn't just check the shaded-client, but for all 
shaded-* modules?


> Make hbase-shaded-check-invariants part of precommit
> ----------------------------------------------------
>
>                 Key: HBASE-18760
>                 URL: https://issues.apache.org/jira/browse/HBASE-18760
>             Project: HBase
>          Issue Type: Bug
>          Components: community, test
>            Reporter: Appy
>            Assignee: Sean Busbey
>            Priority: Blocker
>         Attachments: HBASE-18760.0.patch, HBASE-18760.1.patch, 
> HBASE-18760.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to