[ 
https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160703#comment-16160703
 ] 

Sean Busbey commented on HBASE-18782:
-------------------------------------

I'm rebasing my work to move to yetus audience annotation in HBASE-17823 and I 
just got to the impact of this commit. to make sure I'm not undoing any of your 
intent here [~stack], I wanted to check in. At the moment, I've got the 
dependency on yetus annotations put into the hbase-build-configuration pom, 
essentially using it as short hand for "any hbase module with java code should 
have this dependency". With that change in place, the few modules where you've 
removed annotation (e.g. hbase-external-blockcache) will have the annotations 
jar as a dependency and I can put back in the explicit IA.Private. Is that 
fine, or would you prefer I make it so that the dep doesn't show up?

> Module untangling work
> ----------------------
>
>                 Key: HBASE-18782
>                 URL: https://issues.apache.org/jira/browse/HBASE-18782
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0-alpha-3
>
>         Attachments: HBASE-18782.master.001.patch, 
> HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, 
> HBASE-18782.master.003.patch
>
>
> Here is a bit of module untangling work done using structure 101. In a few 
> places we depend on modules but are not making use of the dependency. In 
> other places we depended on a module just because we had one references only, 
> one we could undo.
> After this little exercise, we have nicer layering and stuff like 
> hbase-protocol and hbase-protocol-shaded no longer depend on other hbase 
> components.  Not everything depends on annotations anymore.
> There is way more work to do here but this will do for now.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to