[
https://issues.apache.org/jira/browse/HBASE-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-18733:
--------------------------
Attachment: 18733.txt
$ git diff
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
index bce510336b..ee25b926ea 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
@@ -61,7 +61,7 @@ import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
*/
// TODO: Key and WALEdit are never used separately, or in one-to-many
relation, for practical
// purposes. They need to be merged into WALEntry.
[email protected](HBaseInterfaceAudience.REPLICATION)
[email protected]
public class WALKey implements SequenceId, Comparable<WALKey> {
/**
@@ -644,4 +644,4 @@ public class WALKey implements SequenceId,
Comparable<WALKey> {
}
return size;
}
-}
\ No newline at end of file
+}
> [compat 1-2] Hide WALKey
> ------------------------
>
> Key: HBASE-18733
> URL: https://issues.apache.org/jira/browse/HBASE-18733
> Project: HBase
> Issue Type: Sub-task
> Components: API
> Reporter: stack
> Assignee: Sean Busbey
> Fix For: 2.0.0-alpha-3
>
> Attachments: 18733.txt
>
>
> It has all the below issues and it uses our internal PB. See head of class
> where it says it should go away...
> hbase-server-1.0.0.jar, WALEdit.class
> package org.apache.hadoop.hbase.regionserver.wal
> [−] WALEdit.getCompaction ( Cell kv ) [static] :
> WALProtos.CompactionDescriptor 1
> org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$CompactionDescriptor;
> Change Effect
> 1 Return value type has been changed from
> org.apache.hadoop.hbase.protobuf.generated.WALProtos.CompactionDescriptor to
> org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.CompactionDescriptor.
> This method has been removed because the return type is part of the method
> signature. A client program may be interrupted by NoSuchMethodError exception.
> [+] WALEdit.getFlushDescriptor ( Cell cell ) [static] :
> WALProtos.FlushDescriptor 1
> [+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] :
> WALProtos.RegionEventDescriptor 1
> hbase-server-1.0.0.jar, WALKey.class
> package org.apache.hadoop.hbase.wal
> [+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) :
> WALProtos.WALKey.Builder 1
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
