[
https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164295#comment-16164295
]
stack commented on HBASE-17823:
-------------------------------
Does it mean we can have errorprone in hbase2? We'd have to do a bit more work
it seems since you have the bare minimum of hbase-build-configuration module.
We are in a bit of limbo at the mo with this patch in master but not in
hbase2... and it touches everything so all patches from here on on out are not
going to cherry-pick easy. For that reason we should just commit this to
branch-2 (smile).
Other reasons to commit to branch-2 are the nice code removals and removal of
hbase-annotations from a few poms.
I skimmed the 1.8 megs of one line changes... seems fine (again -- smile).
The new hbase-build-configuration/pom.xml depends on hbase-annotations test. It
needs it?
Thanks for the changes that allow us remove this hackery of mine:
4 // @InterfaceAudience.Private
55 // This class has NO InterfaceAudience. It is commented out. We do not
want to import
56 // InterfaceAudience. This would be only class in this module with the
IA import and we do not want
57 // to have this module depend annotations module just for one class.
58 // NO InterfaceAudience defaults to mean InterfaceAudience.Private!
55 @InterfaceAudience.Private
I think its fine [~busbey] Even in branch-2 we'll be wanting to build out
hbase-build-configuration facility. +1
> Migrate to Apache Yetus Audience Annotations
> --------------------------------------------
>
> Key: HBASE-17823
> URL: https://issues.apache.org/jira/browse/HBASE-17823
> Project: HBase
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.0.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch,
> HBASE-17823.2.patch, HBASE-17823.3.patch, HBASE-17823-branch-2.v3.patch
>
>
> Migrate from our own audience annotation handling to apache yetus'
> implementation.
> [discussion thread on
> dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
