[
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186128#comment-13186128
]
Benoit Sigoure commented on HBASE-3939:
---------------------------------------
No, I'm just trying to make sense of what's doing what. I don't understand
what this Status is intended for, it's just unused and wasting 4 bytes on every
RPC. The ProtocolSignature thing is also unclear to me. It doesn't seem to be
used either and also adds an extra 4 bytes per RPC. To top things up nicely,
there is also an extra 8 bytes added per RPC for the clientVersion that this is
always set to zero because, as a comment in the code says, "VersionedProtocol
is exempted from version check".
I don't understand what's the point of any of this stuff, so I thought maybe
someone could shed some light on the reasons why things are the way they are.
> Some crossports of Hadoop IPC fixes
> -----------------------------------
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt,
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939-v9.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of
> date IPC version
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
