[
https://issues.apache.org/jira/browse/HBASE-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165423#comment-16165423
]
Hadoop QA commented on HBASE-14127:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
21s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
45s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 17s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}331m 2s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}367m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
|
| | hadoop.hbase.util.TestHBaseFsck |
| | hadoop.hbase.client.TestAdmin2 |
| | hadoop.hbase.master.TestMasterBalanceThrottling |
| | hadoop.hbase.snapshot.TestRegionSnapshotTask |
| |
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
| | hadoop.hbase.security.access.TestAccessController3 |
| Timed out junit tests |
org.apache.hadoop.hbase.master.TestMasterMetricsWrapper |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.replication.regionserver.TestReplicator |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.master.TestMasterFailover |
| | org.apache.hadoop.hbase.master.TestGetInfoPort |
| | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.regionserver.TestRegionReplicas |
| | org.apache.hadoop.hbase.coprocessor.TestMasterObserver |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort |
| | org.apache.hadoop.hbase.client.TestMetaWithReplicas |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort |
| |
org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster |
| | org.apache.hadoop.hbase.master.TestTableLockManager |
| | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS |
| | org.apache.hadoop.hbase.TestClusterBootOrder |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded |
| | org.apache.hadoop.hbase.master.TestDeadServer |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential |
| | org.apache.hadoop.hbase.master.TestMasterShutdown |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController
|
| | org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush |
| | org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint |
| | org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
|
| | org.apache.hadoop.hbase.master.TestMaster |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster |
| | org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint |
| | org.apache.hadoop.hbase.snapshot.TestExportSnapshot |
| | org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
| | org.apache.hadoop.hbase.TestRegionRebalancing |
| | org.apache.hadoop.hbase.client.TestReplicaWithCluster |
| |
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters
|
| | org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase |
| | org.apache.hadoop.hbase.master.TestRestartCluster |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel |
| | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing |
| | org.apache.hadoop.hbase.master.TestWarmupRegion |
| | org.apache.hadoop.hbase.client.TestHCM |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname |
| | org.apache.hadoop.hbase.regionserver.TestClusterId |
| | org.apache.hadoop.hbase.client.TestTableSnapshotScanner |
| | org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat |
| | org.apache.hadoop.hbase.client.TestMultiParallel |
| | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient |
| | org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
|
| | org.apache.hadoop.hbase.TestMetaTableAccessor |
| | org.apache.hadoop.hbase.master.handler.TestEnableTableHandler |
| | org.apache.hadoop.hbase.master.handler.TestCreateTableHandler |
| |
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters |
| | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover |
| | org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat |
| | org.apache.hadoop.hbase.client.TestScannersFromClientSide |
| | org.apache.hadoop.hbase.replication.TestMasterReplication |
| | org.apache.hadoop.hbase.regionserver.TestAtomicOperation |
| | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
| | org.apache.hadoop.hbase.client.TestMetaScanner |
| | org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat |
| | org.apache.hadoop.hbase.tool.TestCanaryTool |
| | org.apache.hadoop.hbase.util.TestFSUtils |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:6f1cc2c |
| JIRA Issue | HBASE-14127 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12771203/HBASE-14127-branch-1.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 98f9e65772a1 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1 / a8ac84f |
| Default Java | 1.7.0_151 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_144
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_151 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8612/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8612/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8612/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Refactor AssignmentManager.unassign() function which has lots of return
> statements
> ----------------------------------------------------------------------------------
>
> Key: HBASE-14127
> URL: https://issues.apache.org/jira/browse/HBASE-14127
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Priority: Minor
> Attachments: HBASE-14127-branch-1.patch, HBASE-14127-master.patch,
> HBASE-14127-master-v2.patch
>
>
> In AssignmentManager.unassign()
> * there are lots of return points
> * if condition is very non-trivial to understand
> * reuse of 'state' for different purpose makes things confusing
> A simple unfold of if-else with with better variable names should be
> sufficient.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
