[
https://issues.apache.org/jira/browse/HBASE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165557#comment-16165557
]
Hadoop QA commented on HBASE-18766:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
26s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
45m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 53s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}157m 9s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.TestMasterMetricsWrapper |
| | org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.master.TestMasterFailover |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
| | org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
| |
org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster |
| | org.apache.hadoop.hbase.master.TestTableStateManager |
| | org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner |
| | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
|
| | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash |
| | org.apache.hadoop.hbase.master.TestSplitLogManager |
| | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS |
| | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport |
| | org.apache.hadoop.hbase.master.TestRollingRestart |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| | org.apache.hadoop.hbase.master.TestMasterShutdown |
| | org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks |
| | org.apache.hadoop.hbase.master.TestCatalogJanitorInMemoryStates |
| | org.apache.hadoop.hbase.master.TestMaster |
| |
org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient
|
| |
org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
|
| | org.apache.hadoop.hbase.TestAcidGuarantees |
| |
org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency
|
| | org.apache.hadoop.hbase.master.TestRestartCluster |
| | org.apache.hadoop.hbase.master.TestWarmupRegion |
| | org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions |
| | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure |
| | org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure |
| |
org.apache.hadoop.hbase.master.procedure.TestFastFailOnProcedureNotRegistered |
| | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
| | org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18766 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12886969/HBASE-18766.v0.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f36aab7a87e9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8bbfc83 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8619/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8619/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8619/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Make TableSnapshotScanner Audience Private
> ------------------------------------------
>
> Key: HBASE-18766
> URL: https://issues.apache.org/jira/browse/HBASE-18766
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: Chia-Ping Tsai
> Labels: beginner
> Attachments: HBASE-18766.v0.patch
>
>
> From HBASE-10462 API cleanup. TableSnapshotScanner should be Audience
> Private. It should not be public. See HBASE-10462 for [~enis] rationale. If
> private, then there needs to be a way to construct it. It is awkward since we
> normally construct 'Table' by getting one from a Connection. Enis suggests:
> bq. Maybe we can do a SnapshotConnection which returns a ConnectionTable,
> which returns the scanner. Since connection is the factory to everything, I
> think this approach is the most clean.
> Sounds good.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
