[ 
https://issues.apache.org/jira/browse/HBASE-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165944#comment-16165944
 ] 

Yechao Chen edited comment on HBASE-18772 at 9/14/17 8:31 AM:
--------------------------------------------------------------

ReflectionUtils.newInstance(queueClass, queueInitArgs));
 queueInitArgs = new Object[] { maxQueueLength, codelTargetDelay, codelInterval,
          codelLifoThreshold, numGeneralCallsDropped, numLifoModeSwitches };

Sorry for 
that,RpcExecutor#numGeneralCallsDropped,RpcExecutor#numLifoModeSwitches need to 
change LongADDER.
will submit a patch later


        



was (Author: chenyechao):

ReflectionUtils.newInstance(queueClass, queueInitArgs));
 queueInitArgs = new Object[] { maxQueueLength, codelTargetDelay, codelInterval,
          codelLifoThreshold, {color:red}numGeneralCallsDropped{color}, 
{color:red}numLifoModeSwitches {color}};

Sorry for 
that,RpcExecutor#numGeneralCallsDropped,RpcExecutor#numLifoModeSwitches need to 
change LongADDER.
will submit a patch later


        


> [JDK8]  Replace AtomicLong with LongAdder
> -----------------------------------------
>
>                 Key: HBASE-18772
>                 URL: https://issues.apache.org/jira/browse/HBASE-18772
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha-2
>            Reporter: Yechao Chen
>            Assignee: Yechao Chen
>            Priority: Trivial
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18772.master.patch, HBASE-18772.master-v2.patch, 
> HBASE-18772.master-v3.patch, HBASE-18772.master-v4.patch
>
>
> Currently we use many AtomicLong in HBase Region Code ,such as BucketCache 
> calss realCacheSize,heapSize,blockNumber,accessCount  and HRegion calss  
> compactionNumBytesCompacted etc .
> In JDK8 LongAdder  is faster than AtomicLong ,should use this replace  
> AtomicLong 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to