[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168027#comment-16168027
]
Reid Chan edited comment on HBASE-18651 at 9/15/17 3:56 PM:
------------------------------------------------------------
I have observed other classes in hbase-it, none of them has annotation for
audience.
{{ChaosMonkeyRunner}} in {{Monkeys}} already extends {{AbstractHBaseTool}} and
implements required methods.
{{IntegrationTestMonkeys}} doesn't have to extends {{IntegrationTestBase}}
again, this test, just proving it has controls on {{ChaosMonkeyRunner}}, is
enough in my opinions.
was (Author: reidchan):
I have observed other classes in hbase-it, none of them has annotation for
audience.
{{ChaosMonkeyRunner}} in {{Monkeys}} already extends {{AbstractHBaseTool}} and
implements required methods.
{{Monkeys}} don't have to extends {{IntegrationTestBase}} again, this test,
just proving it has controls on {{ChaosMonkeyRunner}}, is enough in my opinions.
> Let ChaosMonkeyRunner expose the chaos monkey runner it creates
> ---------------------------------------------------------------
>
> Key: HBASE-18651
> URL: https://issues.apache.org/jira/browse/HBASE-18651
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Reid Chan
> Attachments: HBASE-18651.master.001.patch,
> HBASE-18651.master.002.patch
>
>
> Currently ChaosMonkeyRunner#main() instantiates ChaosMonkeyRunner without
> keeping track of the instance.
> This poses some challenge when ChaosMonkeyRunner is used programmatically
> because the caller cannot get hold of the runner.
> As [~mdrob] suggested, we should expose the chaos monkey runner.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
