[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169002#comment-16169002 ]
Andrew Purtell commented on HBASE-18829: ---------------------------------------- I want to see rigorous testing of this change before we commit it. I don't want a repeat of the storefile locking change. Rigorous implies ~24 hours of testing with ITBLL. I will insist on post of evidence of positive results like this before a commit, thanks. I think everyone can appreciate the abundance of caution. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > ------------------------------------------------------------------------------------------- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)