[ 
https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169024#comment-16169024
 ] 

Ted Yu commented on HBASE-18415:
--------------------------------

{code}
+import org.apache.hadoop.hbase.ipc.*;
{code}
Wildcard should not be used.

ReuseNonceMasterCallable -> NonceReusingMasterCallable
{code}
+    ReuseNonceMasterCallable(HConnection con, NonceGenerator ng) {
+      super(con);
+      this.ng = ng;
+      group = ng.getNonceGroup();
+      nonce = ng.newNonce();
{code}
Do we need to keep reference to NonceGenerator and the (group, nounce) pair at 
the same time ?



> The local timeout may cause Admin to submit duplicate request
> -------------------------------------------------------------
>
>                 Key: HBASE-18415
>                 URL: https://issues.apache.org/jira/browse/HBASE-18415
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
>         Attachments: HBASE-18415.branch-1.ut.patch, 
> HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, 
> HBASE-18415.branch-1.v2.patch
>
>
> After a timeout occurs on first request, client will retry the request with 
> distinct group/nonce. The second request may bring the TableXXXException back 
> if the first request have changed the table state.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to