[
https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186370#comment-13186370
]
Zhihong Yu commented on HBASE-5201:
-----------------------------------
I tried the following change on pom.xml and trunk compiles:
{code}
@@ -887,7 +887,7 @@
<protobuf.version>2.4.0a</protobuf.version>
<slf4j.version>1.5.8</slf4j.version><!-- newer version available -->
<stax-api.version>1.0.1</stax-api.version>
- <thrift.version>0.7.0</thrift.version>
+ <thrift.version>0.8.0</thrift.version>
<zookeeper.version>3.4.2</zookeeper.version>
<hadoop-snappy.version>0.0.1-SNAPSHOT</hadoop-snappy.version>
{code}
We should reuse classes from libthrift-0.8.0.jar:
{code}
2977 Sat Nov 26 17:05:38 PST 2011
org/apache/thrift/server/AbstractNonblockingServer.class
18666 Sat Nov 26 14:00:40 PST 2011
org/apache/thrift/server/AbstractNonblockingServer.java
{code}
Please incorporate the change in pom.xml and submit a new patch.
Thanks
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and
> HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-5201
> URL: https://issues.apache.org/jira/browse/HBASE-5201
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not
> limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in
> thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
