[
https://issues.apache.org/jira/browse/HBASE-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170032#comment-16170032
]
Dima Spivak commented on HBASE-18834:
-------------------------------------
+1
> fix shellcheck warning on hbase personality
> -------------------------------------------
>
> Key: HBASE-18834
> URL: https://issues.apache.org/jira/browse/HBASE-18834
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Minor
> Attachments: HBASE-18834.0.patch
>
>
> current shellcheck gives us two warnings:
> {code}
> $ shellcheck dev-support/hbase-personality.sh
> In dev-support/hbase-personality.sh line 123:
> if [[ $? -eq 0 ]]; then
> ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not
> indirectly with $?.
> In dev-support/hbase-personality.sh line 136:
> if [[ $? -eq 0 ]]; then
> ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not
> indirectly with $?.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
