[
https://issues.apache.org/jira/browse/HBASE-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170551#comment-16170551
]
Hudson commented on HBASE-18808:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3736 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3736/])
HBASE-18808 Ineffective config check in (tedyu: rev
9f0863ce5f25276e22ac0d3b2c03b4f6f2296578)
* (edit)
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java
> Ineffective config check in BackupLogCleaner#getDeletableFiles()
> ----------------------------------------------------------------
>
> Key: HBASE-18808
> URL: https://issues.apache.org/jira/browse/HBASE-18808
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Reid Chan
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18808.master.001.patch
>
>
> Here is related code:
> {code}
> if (this.getConf() == null || !BackupManager.isBackupEnabled(getConf())) {
> LOG.warn("Backup is not enabled. Check your " +
> BackupRestoreConstants.BACKUP_ENABLE_KEY
> + " setting");
> return files;
> }
> {code}
> However, in setConf() we don't store the Configuration where backup is
> disabled:
> {code}
> public void setConf(Configuration config) {
> // If backup is disabled, keep all members null
> if (!config.getBoolean(BackupRestoreConstants.BACKUP_ENABLE_KEY,
> BackupRestoreConstants.BACKUP_ENABLE_DEFAULT)) {
> LOG.warn("Backup is disabled - allowing all wals to be deleted");
> return;
> }
> {code}
> This means that once config with backup enabled is remembered, it won't go to
> disabled state.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
