[
https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186574#comment-13186574
]
Hadoop QA commented on HBASE-5201:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510635/HBASE-5201-v4.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -145 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 82 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/764//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/764//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/764//console
This message is automatically generated.
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and
> HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-5201
> URL: https://issues.apache.org/jira/browse/HBASE-5201
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt,
> HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not
> limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in
> thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
