[
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172579#comment-16172579
]
Mike Drob commented on HBASE-18601:
-----------------------------------
In AsyncRequestFutureImpl.java and {{PerformanceEvaluation.java}} there is
{{+import org.apache.hadoop.tracing.TraceUtils;}}
Please document that many of the methods in TraceUtil will return null when not
tracing.
{code:title=IntegrationTestMTTR.java}
+ scope = TraceUtil.createTrace(getSpanName());
+ TraceUtil.addSampler(AlwaysSampler.INSTANCE);
{code}
I think these need to be reversed. Similar comment applies to the other ITs.
TraceTree is big enough to be it's own class, I think. And could use some more
doc.
There's some TODOs hanging about - can you file a JIRA and reference it there?
Overall, I think we're getting close.
> Update Htrace to 4.2
> --------------------
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
> Issue Type: Task
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Tamas Penzes
> Assignee: Tamas Penzes
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18601.master.001.patch,
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch,
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch,
> HBASE-18601.master.004.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy,
> the upgrade to 4.x is not trivial and would take time. It might not worth to
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form
> the use of HTrace 3.2 might not add any value to the project and fixing it
> would be far too much effort.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Based on the decision of the community we keep htrace now and update version
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
