[
https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172815#comment-16172815
]
Anoop Sam John commented on HBASE-18825:
----------------------------------------
bq.For StoreFile, Store, and Region, we will not have multiple implementation
classes so it is not necessary to have an interface for us.
This is not fully true. Though am not sure any one will use, but we do have a
config to plugin region impl. "hbase.hregion.impl". This is in place from long
time.. But in our code many a places we type casting to HRegion. So am sure
no one would be having extension. We should clean this up also I believe.
The issue of interface usage and expose that also to CP is there from top most
level that HRS. At least there we can not go with impl way in our code because
the interface way allows us to do mocking in UTs. May be down the layers for
Region, Store etc, this is not a necessary!
bq.What about introducing dedicated interface to CP?
This is also some thing to discuss. We can compare the pros and cons of each
approach and take the best.
> Use HStoreFile instead of StoreFile in our own code base and remove
> unnecessary methods in StoreFile interface
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-18825
> URL: https://issues.apache.org/jira/browse/HBASE-18825
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18825.patch, HBASE-18825-v1.patch,
> HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch
>
>
> Use generic types to avoid too many casts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
