[ 
https://issues.apache.org/jira/browse/HBASE-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172844#comment-16172844
 ] 

stack commented on HBASE-18853:
-------------------------------

.002 Add nothing changes to server and client so get their tests exercised....

> hbase-protocol-shaded includes protobuf (since we moved to hbase-thirdparty)
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-18853
>                 URL: https://issues.apache.org/jira/browse/HBASE-18853
>             Project: HBase
>          Issue Type: Bug
>          Components: thirdparty
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18853.master.001.patch, 
> HBASE-18853.master.002.patch
>
>
> I didn't follow my own comment when I added hbase-thirdparty 
> hbase-shaded-protobuf to hbase-shaded-protocol as a dependency instead of 
> original protobuf. It meant that our jar had protobuf bundled up inside it.
> Change is small, and I don't think we were actually using the non-shaded 
> protobuf anywhere, but if anyone was, it'd make for interesting issue to 
> debug. Let me see if it breaks anything...
> (Found by our [~vickyuec] on internal deploy...)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to