[ https://issues.apache.org/jira/browse/HBASE-17399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173759#comment-16173759 ]
Hadoop QA commented on HBASE-17399: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 24s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 18s{color} | {color:green} branch-1.3 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 50s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 7s{color} | {color:red} The patch generated 1 new + 322 unchanged - 4 fixed = 323 total (was 326) {color} | | {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m 2s{color} | {color:green} There were no new ruby-lint issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 42s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 38m 22s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 47s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 47m 37s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b3a2a00 | | JIRA Issue | HBASE-17399 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12888109/HBASE-17399.branch-1.3.v1.patch | | Optional Tests | asflicense shadedjars rubocop ruby_lint | | uname | Linux fb7461a1d298 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | branch-1.3 / ee6131f | | rubocop | v0.50.0 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/8716/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8716/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > region_mover.rb uses different default filename, also needs slight change > ------------------------------------------------------------------------- > > Key: HBASE-17399 > URL: https://issues.apache.org/jira/browse/HBASE-17399 > Project: HBase > Issue Type: Bug > Affects Versions: 1.3.0 > Reporter: Lars George > Assignee: ChunHao > Labels: beginner > Attachments: HBASE-17399.branch-1.3.v0.patch, > HBASE-17399.branch-1.3.v1.patch > > > The command line help prints: > {noformat} > -f, --filename=FILE File to save regions list into unloading, \ > or read from loading; default /tmp/<hostname:port> > {noformat} > while in reality, the code does this: > {code} > def getFilename(options, targetServer, port) > filename = options[:file] > if not filename > filename = "/tmp/" + ENV['USER'] + targetServer + ":" + port > end > return filename > end > {code} > An example for a generated file is: > {noformat} > /tmp/larsgeorgeslave-3.internal.larsgeorge.com\:16020 > {noformat} > I suggest we fix the command line help explanation. But first, we should also > fix how the name is generated, *adding* a divider between the user name and > the host name, and also change how the port is attached to the host name. > Currently this results in a rather strange {{\:}} which could be hard to > handle. Maybe we simply use an exclamation mark or hash for both? For example: > {noformat} > /tmp/larsgeorge!slave-3.internal.larsgeorge.com!16020 > /tmp/larsgeorge#slave-3.internal.larsgeorge.com#16020 > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)