[ 
https://issues.apache.org/jira/browse/HBASE-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5205:
---------------------------------

    Description: 
Delete.deleteFamily clears all other markers for the same family.
That is not correct as some of these other markers might be for a later time.

That logic should be removed.

If (really) needed this can be slightly optimized by keeping track of the max 
TS so far for each family.
If both the TS-so-far and the TS of a new deleteFamily request is < 
LATEST_TIMESTAMP and the TS-so-far is < deleteFamily marker, or if both the 
TS-so-far and the new TS equal LATEST_TIMESTAMP, then the previous delete 
markerz for that family could be removed.
I think that might be overkill, as most deletes issued from clients are for 
LATEST_TIMESTAMP (which the server translates to the current time).

I'll have a (one-line) patch soon. Unless folks insist on the optimization I 
mentioned above.

  was:
Delete.deleteFamily clears all other markers for the same family.
That is not correct as some of these other markers might be for a later time.

That logic should be removed.

If (really) needed this can be slightly optimized by keeping track of the max 
TS so far for each family.
If both the TS-so-far and the TS of a new deleteFamily request is < 
LATEST_TIMESTAMP and the TS-so-far is < deleteFamily marker, then the previous 
delete marker can be removed.
I think that might be overkill, as most deletes issued from clients are for 
LATEST_TIMESTAMP (which the server translates to the current time).

I'll have a (one-line) patch soon. Unless folks insist on the optimization I 
mentioned above.

    
> Delete handles deleteFamily incorrectly
> ---------------------------------------
>
>                 Key: HBASE-5205
>                 URL: https://issues.apache.org/jira/browse/HBASE-5205
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>            Reporter: Lars Hofhansl
>            Priority: Minor
>         Attachments: 5205.txt
>
>
> Delete.deleteFamily clears all other markers for the same family.
> That is not correct as some of these other markers might be for a later time.
> That logic should be removed.
> If (really) needed this can be slightly optimized by keeping track of the max 
> TS so far for each family.
> If both the TS-so-far and the TS of a new deleteFamily request is < 
> LATEST_TIMESTAMP and the TS-so-far is < deleteFamily marker, or if both the 
> TS-so-far and the new TS equal LATEST_TIMESTAMP, then the previous delete 
> markerz for that family could be removed.
> I think that might be overkill, as most deletes issued from clients are for 
> LATEST_TIMESTAMP (which the server translates to the current time).
> I'll have a (one-line) patch soon. Unless folks insist on the optimization I 
> mentioned above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to