[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175950#comment-16175950 ]
ramkrishna.s.vasudevan commented on HBASE-18825: ------------------------------------------------ bq.What about StoreFile? I'm thinking about alternate HFile implementations. What if someone wants to plug in a columnar-based file format? Or we want to do a V4 of HFile. This is harder for me to swallow. This question comes because we have StoreFile, Hfile, StorefileREader, HFileReader, StoreFileScanner etc. I think StoreFile is only giving some meta data info about that HFile. So should be good here. >From RB bq.But here I can see initReader() and getReader() removed but closeReader and deleteREader() are there. I think that closeReader should ideally be closeStoreFile() and deleteStoreFile()? I think they need not be there in StoreFile and be exposed to CP. Rest LGTM. +1 > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -------------------------------------------------------------------------------------------------------------- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)