[ 
https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178179#comment-16178179
 ] 

Chia-Ping Tsai commented on HBASE-16290:
----------------------------------------

You need to rebase the patch.

{code}
+
+public class CallQueueInfo {
{code}
add IA.Private 

{code}
+    Map<String, Map<String, Long>> callQueueMethodCountsSummary;
+    Map<String, Map<String, Long>> callQueueMethodSizeSummary;
+
+    public CallQueueInfo() {
+        callQueueMethodCountsSummary = new HashMap<>();
+        callQueueMethodSizeSummary = new HashMap<>();
+    }
{code}
Make the fields final. 

{code}
-import java.util.ArrayList;
-import java.util.Comparator;
-import java.util.List;
-import java.util.Locale;
+import java.util.*;
{code}
We don't use the glob pattern.

BTW, The tab size is 2 space.

> Dump summary of callQueue content; can help debugging
> -----------------------------------------------------
>
>                 Key: HBASE-16290
>                 URL: https://issues.apache.org/jira/browse/HBASE-16290
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: Sreeram Venkatasubramanian
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: 0001-Changes-for-HBASE-16290.patch, 
> 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample 
> Summary.txt
>
>
> Being able to get a clue what is in a backedup callQueue could give insight 
> on what is going on on a jacked server. Just needs to summarize count, sizes, 
> call types. Useful debugging. In a servlet?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to