[ 
https://issues.apache.org/jira/browse/HBASE-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178644#comment-16178644
 ] 

Abhishek Singh Chouhan commented on HBASE-18796:
------------------------------------------------

I believe that branch-1.3's scan code doesn't suffer from the bug that the 
addendum is solving and hence should not be needed there. branch-1.3 uses 
ClientSmallReversedScanner for the scan, the loadCache method in 
ClientSmallReversedScanner doesn't modify the passed in scan object's caching, 
which is the case in later branches in ClientScanner.java
 
if (scan.getLimit() >0) {
int newLimit = scan.getLimit() - numberOfCompleteRows;
assert newLimit >=0;
scan.setLimit(newLimit);
}
The original change however still applies to branch-1.3. I ran the test suite 
locally and the tests pass for me.
Will commit the original change to branch-1.3 later today unless objections.

> Admin#isTableAvailable returns incorrect result before daughter regions are 
> opened
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-18796
>                 URL: https://issues.apache.org/jira/browse/HBASE-18796
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.3.1
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>             Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
>         Attachments: HBASE-18796-addendum.branch-1.patch, 
> HBASE-18796-addendum.master.patch, HBASE-18796.branch-1.001.patch, 
> HBASE-18796.branch-1.001.patch, HBASE-18796.branch-1.002.patch, 
> HBASE-18796.branch-1.003.patch, HBASE-18796.master.001.patch
>
>
> Admin#isTableAvailable checks if it can getServerName for the meta entries it 
> reads. During the time of split server location are added to the meta entries 
> in MetaTableAccessor#splitRegion although the description of the method says 
> "Does not add the location information to the daughter regions since they are 
> not open yet.". At this point during the split daughter regions are not 
> actually open, so we can get to a state where parent is offline, daughters 
> are not yet open but isTableAvailable returns true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to