[
https://issues.apache.org/jira/browse/HBASE-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180018#comment-16180018
]
Andrew Purtell commented on HBASE-18830:
----------------------------------------
lgtm
Will commit
> TestCanaryTool does not check Canary monitor's error code
> ---------------------------------------------------------
>
> Key: HBASE-18830
> URL: https://issues.apache.org/jira/browse/HBASE-18830
> Project: HBase
> Issue Type: Bug
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Attachments: HBASE-18830.001.patch
>
>
> None of the tests inside TestCanaryTool check Canary monitor's error code.
> Thus, it is possible that the monitor has registered an error and yet the
> tests pass. We should check the value returned by the _ToolRunner.run()_
> method inside each unit test.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
