[ 
https://issues.apache.org/jira/browse/HBASE-18826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180235#comment-16180235
 ] 

stack commented on HBASE-18826:
-------------------------------

Patch looks good to me. +1

That refactor with getStoreFileAgeStream looks good but we sure it returns the 
right answer? Is there test coverage for it?

The purge of deprecated stuff is great.

+1







> Use HStore instead of Store in our own code base and remove unnecessary 
> methods in Store interface
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18826
>                 URL: https://issues.apache.org/jira/browse/HBASE-18826
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18826.patch, HBASE-18826-v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to