[
https://issues.apache.org/jira/browse/HBASE-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180925#comment-16180925
]
Andrew Purtell edited comment on HBASE-18762 at 9/26/17 3:19 PM:
-----------------------------------------------------------------
I'll correct the warning with an addendum.
To answer the question posed
bq. Seem no pre commit check for the patch here? Why?
I've been struggling on multiple recent issues evaluating patches for commit
with false positive precommit reports, failures on ASF test infra that can
never be reproduced in any environment I have access to. This has been the
usual state of affairs of ASF test infra for as long as I can remember. I have
the impression precommit reports are worthless, which is my mistake, because at
least the findbugs report has value. I'll wait for precommit in the future.
Apologies for the slip up.
Edit: Worthless not because of the time invested in Yetus, or authoring tests,
or spending countless volunteer time on test-only issues, but because the ASF
test environments are so unstable.
was (Author: apurtell):
I'll correct the warning with an addendum.
To answer the question posed
bq. Seem no pre commit check for the patch here? Why?
I've been struggling on multiple recent issues evaluating patches for commit
with false positive precommit reports, failures on ASF test infra that can
never be reproduced in any environment I have access to. This has been the
usual state of affairs of ASF test infra for as long as I can remember. I have
the impression precommit reports are worthless, which is my mistake, because at
least the findbugs report has value. I'll wait for precommit in the future.
Apologies for the slip up.
> Canary sink type cast error
> ---------------------------
>
> Key: HBASE-18762
> URL: https://issues.apache.org/jira/browse/HBASE-18762
> Project: HBase
> Issue Type: Bug
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18762.001.patch
>
>
> When running the main method of Canary.java, we see the following error:
> Exception in thread "main" java.lang.ClassCastException:
> org.apache.hadoop.hbase.tool.Canary$RegionServerStdOutSink cannot be cast to
> org.apache.hadoop.hbase.tool.Canary$RegionStdOutSink
> at org.apache.hadoop.hbase.tool.Canary.newMonitor(Canary.java:911)
> at org.apache.hadoop.hbase.tool.Canary.run(Canary.java:796)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.hbase.tool.Canary.main(Canary.java:1571)
> This happens because we typecast the sink depending on the mode (zookeeper
> mode/region server mode) that Canary is configured in. In case no mode is
> specified, we typecast the sink into _RegionStdOutSink_. In general, it is
> possible to provide inconsistent mode and sink types while running Canary.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
