[
https://issues.apache.org/jira/browse/HBASE-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181201#comment-16181201
]
Andrew Purtell commented on HBASE-18762:
----------------------------------------
Pushed addendum to branch-1.4 and up. No need to catch a runtime exception when
getting the sink and erroneously falling through because there is already an
outer catch that does the same handling. Also noticed and fixed where a check
for proper configuration of the -readTableTimeouts option does the same thing
of setting the error code and falling through when it shouldn't. Ran a local
findbugs analysis on Canary.java, all clear on all four commit
targets/branches. TestCanaryTool passes on all four branches as well.
> Canary sink type cast error
> ---------------------------
>
> Key: HBASE-18762
> URL: https://issues.apache.org/jira/browse/HBASE-18762
> Project: HBase
> Issue Type: Bug
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18762.001.patch, HBASE-18830-addendum.patch
>
>
> When running the main method of Canary.java, we see the following error:
> Exception in thread "main" java.lang.ClassCastException:
> org.apache.hadoop.hbase.tool.Canary$RegionServerStdOutSink cannot be cast to
> org.apache.hadoop.hbase.tool.Canary$RegionStdOutSink
> at org.apache.hadoop.hbase.tool.Canary.newMonitor(Canary.java:911)
> at org.apache.hadoop.hbase.tool.Canary.run(Canary.java:796)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.hbase.tool.Canary.main(Canary.java:1571)
> This happens because we typecast the sink depending on the mode (zookeeper
> mode/region server mode) that Canary is configured in. In case no mode is
> specified, we typecast the sink into _RegionStdOutSink_. In general, it is
> possible to provide inconsistent mode and sink types while running Canary.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
