[
https://issues.apache.org/jira/browse/HBASE-18884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184816#comment-16184816
]
stack commented on HBASE-18884:
-------------------------------
I pushed a super-minor amendment adding a README to the new design-doc
directory explaining what it is for, warning that design may not match
implementation, and noting when this effort started.
On the patch, I'm +1 but I think a bit of javadoc on what happens when
getServices returns no Service -- the default -- is needed in the Interface.
> Coprocessor Design Improvements follow up of HBASE-17732
> --------------------------------------------------------
>
> Key: HBASE-18884
> URL: https://issues.apache.org/jira/browse/HBASE-18884
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors
> Reporter: Appy
> Assignee: Appy
> Labels: incompatible
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18884.master.001.patch
>
>
> Creating new jira to track suggestions that came in review
> (https://reviews.apache.org/r/62141/) but are not blocker and can be done
> separately.
> Suggestions by [~apurtell]
> - Change {{Service Coprocessor#getService()}} to {{List<Service>
> Coprocessor#getServices()}}
> - I think we overstepped by offering [table resource management via this
> interface|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java#L57].
> There are a lot of other internal resource types which could/should be
> managed this way but they are all left up to the implementor. Perhaps we
> should remove the table ref management and leave it up to them as well.
> ----
> - Checkin the finalized design doc into repo
> (https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit)
> (fyi: [~stack])
> - Added example to javadoc of Coprocessor base interface on how to implement
> one in the new design
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
