[ https://issues.apache.org/jira/browse/HBASE-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186749#comment-16186749 ]
Hadoop QA commented on HBASE-18703: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 46s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 25s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 47s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 0s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 37m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 22s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 68m 21s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 55s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}131m 59s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence | | | org.apache.hadoop.hbase.coprocessor.TestHTableWrapper | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.client.TestFromClientSide | | | org.apache.hadoop.hbase.client.TestMultipleTimestamps | | | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.master.TestMasterFailover | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics | | | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics | | | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.client.TestAsyncTableBatch | | | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook | | | org.apache.hadoop.hbase.TestFullLogReconstruction | | | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint | | | org.apache.hadoop.hbase.TestMultiVersions | | | org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups | | | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | org.apache.hadoop.hbase.wal.TestWALFiltering | | | org.apache.hadoop.hbase.coprocessor.TestCoprocessorMetrics | | | org.apache.hadoop.hbase.security.access.TestAccessController2 | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi | | | org.apache.hadoop.hbase.filter.TestFilterWrapper | | | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver | | | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi | | | org.apache.hadoop.hbase.master.TestGetInfoPort | | | org.apache.hadoop.hbase.client.TestAsyncDrainAdminApi | | | org.apache.hadoop.hbase.client.TestAsyncRegionLocatorTimeout | | | org.apache.hadoop.hbase.client.TestAsyncQuotaAdminApi | | | org.apache.hadoop.hbase.client.TestAsyncTableAdminApi | | | org.apache.hadoop.hbase.wal.TestWALSplitCompressed | | | org.apache.hadoop.hbase.master.TestAssignmentListener | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | org.apache.hadoop.hbase.constraint.TestConstraint | | | org.apache.hadoop.hbase.client.TestAsyncToolAdminApi | | | org.apache.hadoop.hbase.client.TestZKAsyncRegistry | | | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits | | | org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster | | | org.apache.hadoop.hbase.client.TestMultiRespectsLimits | | | org.apache.hadoop.hbase.filter.TestScanRowPrefix | | | org.apache.hadoop.hbase.mob.compactions.TestPartitionedMobCompactor | | | org.apache.hadoop.hbase.master.balancer.TestFavoredStochasticLoadBalancer | | | org.apache.hadoop.hbase.quotas.TestRegionSizeUse | | | org.apache.hadoop.hbase.client.TestServerBusyException | | | org.apache.hadoop.hbase.coprocessor.TestMasterObserver | | | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort | | | org.apache.hadoop.hbase.client.TestClientTimeouts | | | org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.ipc.TestRpcClientLeaks | | | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption | | | org.apache.hadoop.hbase.master.TestTableStateManager | | | org.apache.hadoop.hbase.coprocessor.TestWALObserver | | | org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner | | | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | org.apache.hadoop.hbase.client.TestFromClientSide3 | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | org.apache.hadoop.hbase.coprocessor.TestIncrementTimeRange | | | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.TestClusterBootOrder | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.client.TestScannerTimeout | | | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotas | | | org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded | | | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders | | | org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | org.apache.hadoop.hbase.client.TestSplitOrMergeStatus | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster | | | org.apache.hadoop.hbase.security.TestSecureIPC | | | org.apache.hadoop.hbase.client.TestPutWithDelete | | | org.apache.hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors | | | org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks | | | org.apache.hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor | | | org.apache.hadoop.hbase.client.TestAdmin2 | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL | | | org.apache.hadoop.hbase.client.TestAdmin1 | | | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL | | | org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | org.apache.hadoop.hbase.master.TestCatalogJanitorInMemoryStates | | | org.apache.hadoop.hbase.client.TestAsyncBufferMutator | | | org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient | | | org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient | | | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner | | | org.apache.hadoop.hbase.TestAcidGuarantees | | | org.apache.hadoop.hbase.security.access.TestAccessControlFilter | | | org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt | | | org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter | | | org.apache.hadoop.hbase.TestGlobalMemStoreSize | | | org.apache.hadoop.hbase.client.TestSnapshotMetadata | | | org.apache.hadoop.hbase.master.assignment.TestRegionStates | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | org.apache.hadoop.hbase.TestNamespace | | | org.apache.hadoop.hbase.io.encoding.TestChangingEncoding | | | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | org.apache.hadoop.hbase.client.TestCheckAndMutate | | | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks | | | org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter | | | org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots | | | org.apache.hadoop.hbase.client.TestEnableTable | | | org.apache.hadoop.hbase.client.replication.TestReplicationAdmin | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions | | | org.apache.hadoop.hbase.TestInfoServers | | | org.apache.hadoop.hbase.util.TestRegionSplitter | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter | | | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths | | | org.apache.hadoop.hbase.security.access.TestCellACLs | | | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster | | | org.apache.hadoop.hbase.client.TestFastFail | | | org.apache.hadoop.hbase.util.TestRegionMover | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | org.apache.hadoop.hbase.client.TestLeaseRenewal | | | org.apache.hadoop.hbase.filter.TestColumnRangeFilter | | | org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestTimestampsFilter | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.regionserver.TestHRegion | | | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing | | | org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions | | | org.apache.hadoop.hbase.client.TestHCM | | | org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | org.apache.hadoop.hbase.regionserver.TestRegionOpen | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents | | | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization | | | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite | | | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner | | | org.apache.hadoop.hbase.client.TestRawAsyncTablePartialScan | | | org.apache.hadoop.hbase.client.TestAsyncResultScannerCursor | | | org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove | | | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient | | | org.apache.hadoop.hbase.util.TestHBaseFsckMOB | | | org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | org.apache.hadoop.hbase.quotas.TestSuperUserQuotaPermissions | | | org.apache.hadoop.hbase.client.TestMvccConsistentScanner | | | org.apache.hadoop.hbase.regionserver.TestClusterId | | | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname | | | org.apache.hadoop.hbase.regionserver.TestMobStoreScanner | | | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination | | | org.apache.hadoop.hbase.client.TestTableSnapshotScanner | | | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestSmallReversedScanner | | | org.apache.hadoop.hbase.fs.TestBlockReorder | | | org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide | | | org.apache.hadoop.hbase.client.TestFromClientSideNoCodec | | | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient | | | org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort | | | org.apache.hadoop.hbase.client.TestRawAsyncScanCursor | | | org.apache.hadoop.hbase.util.TestConnectionCache | | | org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove | | | org.apache.hadoop.hbase.io.hfile.TestHFileBlock | | | org.apache.hadoop.hbase.snapshot.TestRegionSnapshotTask | | | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover | | | org.apache.hadoop.hbase.client.TestIllegalTableDescriptor | | | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy | | | org.apache.hadoop.hbase.wal.TestWALFactory | | | org.apache.hadoop.hbase.quotas.TestQuotaAdmin | | | org.apache.hadoop.hbase.client.TestIncrementsFromClientSide | | | org.apache.hadoop.hbase.client.TestHTableMultiplexer | | | org.apache.hadoop.hbase.wal.TestFSHLogProvider | | | org.apache.hadoop.hbase.util.TestIdReadWriteLock | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure | | | org.apache.hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | | | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder | | | org.apache.hadoop.hbase.client.TestMetaCache | | | org.apache.hadoop.hbase.client.TestScannersFromClientSide | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable | | | org.apache.hadoop.hbase.client.TestSnapshotFromClient | | | org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort | | | org.apache.hadoop.hbase.regionserver.TestAtomicOperation | | | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | org.apache.hadoop.hbase.client.TestAppendFromClientSide | | | org.apache.hadoop.hbase.client.TestResultSizeEstimation | | | org.apache.hadoop.hbase.io.TestFileLink | | | org.apache.hadoop.hbase.util.TestFSUtils | | | org.apache.hadoop.hbase.regionserver.TestMajorCompaction | | | org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | | | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 | | | org.apache.hadoop.hbase.wal.TestWALSplit | | | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 | | JIRA Issue | HBASE-18703 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12889777/hbase-18703.master.003.patch | | Optional Tests | asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2009f8e3c454 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / b0e1a15 | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC3 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8871/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8871/testReport/ | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8871/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > Inconsistent behavior for preBatchMutate in doMiniBatchMutate and > processRowsWithLocks > -------------------------------------------------------------------------------------- > > Key: HBASE-18703 > URL: https://issues.apache.org/jira/browse/HBASE-18703 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors > Reporter: Duo Zhang > Assignee: Umesh Agashe > Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: hbase-18703.master.001.patch, > hbase-18703.master.002.patch, hbase-18703.master.003.patch > > > In doMiniBatchMutate, the preBatchMutate is called before building WAL, but > in processRowsWithLocks, we suggest the RowProcessor implementation to build > WAL in process method, which is ahead of preBatchMutate. > If a CP modifies the mutations, especially if it removes some cells from the > mutations, then the behavior of processRowsWithLocks is broken. The changes > applied to memstore and WAL will be different. And there is no way to remove > entries from a WALEdit through CP. -- This message was sent by Atlassian JIRA (v6.4.14#64029)