[ 
https://issues.apache.org/jira/browse/HBASE-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186946#comment-16186946
 ] 

Ashish Singhi commented on HBASE-18909:
---------------------------------------

{code}
+   * @deprecated since 2.0 version and will be removed in 3.0 version. Use
+   *             {@link #listTableDescriptors(java.lang.String)} instead.
{code}
The API you are suggesting to use is marked deprecated below in the patch, 
{code}
+   * @deprecated since 2.0 version and will be removed in 3.0 version. Use
+   *             {@link #listTableDescriptors(Pattern)} instead.
    */
+  @Deprecated
   List<TableDescriptor> listTableDescriptors(String regex) throws IOException;
{code}
So we should suggest to use {{listTableDescriptors(Pattern)}} in the first 
place also.

also
{code}
+  @Deprecated
   List<TableDescriptor> listTableDescriptors(String regex) throws IOException;
{code}
There is reference to this method in java doc of other public APIs to use this 
one, I suggest to remove their also and point it to actual API we would like 
user to use.

General practice what I follow is when ever I mark a API as deprecated I 
replace all of its reference from the code with the one we are suggesting to 
use in the java doc. If you also want to do this please also take care of the 
references in ruby scripts...

> Deprecate Admin's methods which used String regex
> -------------------------------------------------
>
>                 Key: HBASE-18909
>                 URL: https://issues.apache.org/jira/browse/HBASE-18909
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18909.master.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to