[
https://issues.apache.org/jira/browse/HBASE-18409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187597#comment-16187597
]
Hadoop QA commented on HBASE-18409:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
23s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
0s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
23s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
30s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 70m 53s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m 56s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
| | org.apache.hadoop.hbase.TestFullLogReconstruction |
| | org.apache.hadoop.hbase.coprocessor.TestCoprocessorMetrics |
| | org.apache.hadoop.hbase.TestMultiVersions |
| | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator |
| | org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs |
| |
org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups |
| |
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
|
| | org.apache.hadoop.hbase.filter.TestFilterWrapper |
| | org.apache.hadoop.hbase.security.access.TestAccessController2 |
| | org.apache.hadoop.hbase.replication.TestReplicationStateHBaseImpl |
| | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanRenewLease |
| | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | org.apache.hadoop.hbase.client.TestAsyncQuotaAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncMetaRegionLocator |
| | org.apache.hadoop.hbase.client.TestAsyncRegionLocatorTimeout |
| | org.apache.hadoop.hbase.client.TestAsyncTableAdminApi |
| | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.constraint.TestConstraint |
| | org.apache.hadoop.hbase.client.TestAsyncToolAdminApi |
| | org.apache.hadoop.hbase.client.TestZKAsyncRegistry |
| | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits |
| | org.apache.hadoop.hbase.filter.TestScanRowPrefix |
| | org.apache.hadoop.hbase.coprocessor.TestMasterObserver |
| | org.apache.hadoop.hbase.quotas.TestRegionSizeUse |
| | org.apache.hadoop.hbase.client.TestClientTimeouts |
| | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption |
| | org.apache.hadoop.hbase.coprocessor.TestWALObserver |
| | org.apache.hadoop.hbase.client.TestFromClientSide3 |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
|
| | org.apache.hadoop.hbase.TestClusterBootOrder |
| |
org.apache.hadoop.hbase.coprocessor.TestNegativeMemstoreSizeWithSlowCoprocessor
|
| | org.apache.hadoop.hbase.client.TestScannerTimeout |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotas |
| | org.apache.hadoop.hbase.TestJMXConnectorServer |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded |
| | org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster |
| | org.apache.hadoop.hbase.security.TestSecureIPC |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors
|
| | org.apache.hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor
|
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL
|
| | org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe |
| | org.apache.hadoop.hbase.client.TestAsyncBufferMutator |
| | org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter |
| | org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt |
| | org.apache.hadoop.hbase.security.access.TestAccessControlFilter |
| | org.apache.hadoop.hbase.TestAcidGuarantees |
| | org.apache.hadoop.hbase.TestGlobalMemStoreSize |
| | org.apache.hadoop.hbase.client.TestSnapshotMetadata |
| | org.apache.hadoop.hbase.TestNamespace |
| | org.apache.hadoop.hbase.client.TestClientPushback |
| | org.apache.hadoop.hbase.client.TestCheckAndMutate |
| | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| | org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor |
| | org.apache.hadoop.hbase.TestMovedRegionsCleaner |
| | org.apache.hadoop.hbase.client.TestEnableTable |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots |
| | org.apache.hadoop.hbase.util.TestRegionSplitter |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
|
| | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions |
| | org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
| | org.apache.hadoop.hbase.client.TestAlwaysSetScannerId |
| | org.apache.hadoop.hbase.client.TestFastFail |
| | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster |
| | org.apache.hadoop.hbase.util.TestRegionMover |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths |
| | org.apache.hadoop.hbase.security.access.TestCellACLs |
| | org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports |
| | org.apache.hadoop.hbase.filter.TestColumnRangeFilter |
| | org.apache.hadoop.hbase.security.visibility.TestWithDisabledAuthorization
|
| | org.apache.hadoop.hbase.replication.TestReplicationTableBase |
| | org.apache.hadoop.hbase.client.TestTimestampsFilter |
| | org.apache.hadoop.hbase.TestIOFencing |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel |
| | org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestHCM |
| |
org.apache.hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack |
| | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
|
| | org.apache.hadoop.hbase.client.TestAsyncResultScannerCursor |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack |
| | org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient |
| | org.apache.hadoop.hbase.util.TestHBaseFsckMOB |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass |
| | org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions |
| |
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | org.apache.hadoop.hbase.client.TestMvccConsistentScanner |
| | org.apache.hadoop.hbase.quotas.TestSuperUserQuotaPermissions |
| | org.apache.hadoop.hbase.client.TestTableSnapshotScanner |
| | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination |
| | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestFromClientSideNoCodec |
| |
org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
|
| |
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove |
| | org.apache.hadoop.hbase.snapshot.TestRegionSnapshotTask |
| | org.apache.hadoop.hbase.client.TestRawAsyncScanCursor |
| | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.util.TestConnectionCache |
| | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication |
| | org.apache.hadoop.hbase.security.access.TestZKPermissionWatcher |
| | org.apache.hadoop.hbase.client.TestIncrementsFromClientSide |
| | org.apache.hadoop.hbase.client.TestHTableMultiplexer |
| | org.apache.hadoop.hbase.client.TestMobSnapshotFromClient |
| | org.apache.hadoop.hbase.quotas.TestQuotaAdmin |
| | org.apache.hadoop.hbase.util.TestIdReadWriteLock |
| | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
| | org.apache.hadoop.hbase.client.TestMetaCache |
| | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder |
| | org.apache.hadoop.hbase.replication.TestMasterReplication |
| | org.apache.hadoop.hbase.TestPartialResultsFromClientSide |
| | org.apache.hadoop.hbase.client.TestSnapshotFromClient |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable
|
| | org.apache.hadoop.hbase.replication.TestReplicationSource |
| | org.apache.hadoop.hbase.client.TestResultSizeEstimation |
| | org.apache.hadoop.hbase.client.TestAppendFromClientSide |
| | org.apache.hadoop.hbase.client.TestShortCircuitConnection |
| | org.apache.hadoop.hbase.util.TestFSUtils |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18409 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12889896/0004-HBASE-18409-MetricsConnection-client-metrics-migration.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux 30aa356adc36 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 869b90c |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/8890/artifact/patchprocess/whitespace-tabs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8890/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8890/testReport/ |
| modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client
hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8890/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Migrate Client Metrics from codahale to hbase-metrics
> -----------------------------------------------------
>
> Key: HBASE-18409
> URL: https://issues.apache.org/jira/browse/HBASE-18409
> Project: HBase
> Issue Type: Improvement
> Components: Client, java, metrics
> Affects Versions: 3.0.0
> Reporter: Ronald Macmaster
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments:
> 0001-HBASE-18409-MetricsConnection-client-metrics-migration.patch,
> 0002-HBASE-18409-MetricsConnection-client-metrics-migrati.patch,
> 0003-HBASE-18409-MetricsConnection-client-metrics-migration.patch,
> 0004-HBASE-18409-MetricsConnection-client-metrics-migration.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently, the metrics for hbase-client are tailored for reporting via a
> client-side JMX server.
> The MetricsConnection handles the metrics management and reporting via the
> metrics platform from codahale.
> This approach worked well for hbase-1.3.1 when the metrics platform was still
> relatively young, but it could be improved by using the new
> hbase-metrics-api.
> Now that we have an actual hbase-metrics-api that master, regionserver,
> zookeeper, and other daemons use, it would be good to also allow the client
> to leverage the metrics-api.
> Then, the client could also report its metrics via Hadoop's metrics2 if
> desired or through another platform that utilizes the hbase-metrics-api.
> If left alone, client metrics will continue to be only barely visible through
> a client-side JMX server.
> The migration to the new metrics-api could be done by simply changing the
> Metrics data types from codahale types to hbase-metrics types without
> changing the metrics signatures of MetricsConnection unless completely
> necessary.
> The codahale MetricsRegistry would also have to be exchanged for a
> hbase-metrics MetricsRegistry.
> I found this to be a necessary change after attempting to implement my own
> Reporter to use within the MetricsConnection class.
> I was attempting to create a HadoopMetrics2Reporter that extends the codahale
> ScheduledReporter and reports the MetricsConnection metrics to Hadoop's
> metrics2 system.
> The already existing infrastructure in the hbase-metrics and
> hbase-metrics-api projects could be easily leveraged for a cleaner solution.
> If completed successfully, users could instead access their client-side
> metrics through the hbase-metrics-api.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
