[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192169#comment-16192169
 ] 

stack commented on HBASE-18878:
-------------------------------

In Classes.java, you add

-/*
+/**

For first line when usually you want the opposite... '/*'.

Otherwise, patch LGTM. Fix above on commit.

+1



> Use Optional<T> return types when T can be null
> -----------------------------------------------
>
>                 Key: HBASE-18878
>                 URL: https://issues.apache.org/jira/browse/HBASE-18878
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18878.master.001.patch, HBASE-18878.patch, 
> HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to