[
https://issues.apache.org/jira/browse/HBASE-18931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192303#comment-16192303
]
Appy edited comment on HBASE-18931 at 10/5/17 12:43 AM:
--------------------------------------------------------
Looking into the pattern used in TestAccessController &
TestWithDisabledAuthorization, i think we can improve it by invoking hooks via
CpHosts instead of digging into CP framework's internals.
Second, there is something very wrong with TestAccessController. Individual
tests are not completely isolated. We have TEST_TABLE which was supposed to be
a "constant" for use in basic tests and had a fixed set of perms in
setupBeforeClass. However, now some these are changing perms on it. Which has a
big possibility of testing bugs. I won't be surprised if things start breaking
when we untangle this.
Let me file separate jira for that.
was (Author: appy):
Looking into the pattern used in these tests, i think we can improve it by
invoking hooks via CpHosts instead of digging into CP framework's internals.
Second, there is something very wrong with these tests. Individual tests are
not completely isolated. We have TEST_TABLE which was supposed to be a
"constant" for use in basic tests and had a fixed set of perms in
setupBeforeClass. However, now some these are changing perms on it. Which has a
big possibility of testing bugs. I won't be surprised if things start breaking
when we untangle this.
Let me file separate jira for that.
> Make ObserverContext an interface and remove private/testing methods
> --------------------------------------------------------------------
>
> Key: HBASE-18931
> URL: https://issues.apache.org/jira/browse/HBASE-18931
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Appy
> Assignee: Appy
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18931.master.001.patch
>
>
> ObserverContext is IA.LimitedPrivate because CP implementations want
> getEnvironment(), bypass(), etc.
> We can split interface and implementations (suggested by [~Apache9]).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
