[
https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194008#comment-16194008
]
Appy commented on HBASE-18954:
------------------------------
At first, i moved all the config name variables to Coprocessor class. Was about
to submit the patch, but then moving these constants to hbase-client package
seemed bad because that's adding unnecessary dependency edge between two
modules.
Second thought was, moving them to a new and separate CoprocessorConfigs class
in hbase-server/o/a/h/h/coprocessor i.e. next to CoprocessorHost, but that is
the same pattern as HConstants, and the one we regret.
In the end, it seems like it's best to keep these configs close to the context
they are used. So basically, "hbase.coprocessor.region.classes" should go in
the RegionCpHost.
What do others think? [~Apache9], [~anoopsamjohn] [~stack]
It should either be option 2, if exposing it to third party is important, or
option 3, if you think that confs are for hbase-site.xml and not exposing as
constants is fine.
> Make *CoprocessorHost classes private
> -------------------------------------
>
> Key: HBASE-18954
> URL: https://issues.apache.org/jira/browse/HBASE-18954
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Appy
> Assignee: Appy
> Labels: incompatible
> Fix For: 2.0.0-alpha-4
>
>
> Move out configuration name constants (into Coprocessor class?) and made Host
> classes private.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
