[ 
https://issues.apache.org/jira/browse/HBASE-18410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194740#comment-16194740
 ] 

Sean Busbey edited comment on HBASE-18410 at 10/6/17 3:32 PM:
--------------------------------------------------------------

I'd like to help y'all move this forward so that we have a better shot at 
having things cleaned up for 2.0.0GA.

With HBASE-18957 in place locally, it's plain that HBASE-17678 is causing 
filters to not work as-is in master/branch-2/branch-1/branch-1.4. I want to 
make sure filters behave correctly for the upcoming alpha-4 release.

I think our fastest path forward will be to revert HBASE-17678 and HBASE-18160 
in master/branch-2 and then pick up this work in a feature branch (named 
HBASE-18410). That way we can get the work that's been done so far in a single 
place an iterate on things before bringing it back to a place where it impacts 
downstream functionality.  I expect branch HBASE-18410 to be relatively short 
lived, since I want these improvements ready in time for 2.0.0-beta-1.

I plan to proceed on this later today unless someone has an objection.

Note that once the branch exists, we'll need to name our patches appropriately 
so that precommit can test them. e.g. HBASE-18160's patches would be named like 
{{HBASE-18160\-HBASE\-18410.v5.patch}}. That's 
{{JIRA\-KEY}}\-{{BRANCH}}.v{{patch version}}.patch. Both the "\-" before the 
branch and the ".v" after the branch are needed for precommit to suss out the 
branch name.



was (Author: busbey):
I'd like to help y'all move this forward so that we have a better shot at 
having things cleaned up for 2.0.0GA.

With HBASE-18957 in place locally, it's plain that HBASE-17678 is causing 
filters to not work as-is in master/branch-2. I want to make sure filters 
behave correctly for the upcoming alpha-4 release.

I think our fastest path forward will be to revert HBASE-17678 and HBASE-18160 
in master/branch-2 and then pick up this work in a feature branch (named 
HBASE-18410). That way we can get the work that's been done so far in a single 
place an iterate on things before bringing it back to a place where it impacts 
downstream functionality.  I expect branch HBASE-18410 to be relatively short 
lived, since I want these improvements ready in time for 2.0.0-beta-1.

I plan to proceed on this later today unless someone has an objection.

Note that once the branch exists, we'll need to name our patches appropriately 
so that precommit can test them. e.g. HBASE-18160's patches would be named like 
{{HBASE-18160\-HBASE\-18410.v5.patch}}. That's 
{{JIRA\-KEY}}\-{{BRANCH}}.v{{patch version}}.patch. Both the "\-" before the 
branch and the ".v" after the branch are needed for precommit to suss out the 
branch name.


> FilterList  Improvement. 
> -------------------------
>
>                 Key: HBASE-18410
>                 URL: https://issues.apache.org/jira/browse/HBASE-18410
>             Project: HBase
>          Issue Type: Umbrella
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>             Fix For: 2.0.0-alpha-4
>
>
> FilterList.java is complex now, and we have found some improvements for it.  
> So create an issue to address it.    



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to