[ 
https://issues.apache.org/jira/browse/HBASE-18951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196981#comment-16196981
 ] 

Duo Zhang commented on HBASE-18951:
-----------------------------------

But it is a builder anyway, just followed the Curator naming way... See here:

https://github.com/apache/curator/blob/master/curator-framework/src/main/java/org/apache/curator/framework/CuratorFramework.java

And for the unification of the three methods, do you mean a single method or 
three methods with the same name? RowMutations is not a Mutation so if we want 
a single method then we can only use Row as the parameter, which makes no 
sense... And if we still have three methods, it is not a big problem that we 
use three different names?

Thanks.

> Use Builder pattern to remove nullable parameters for checkAndXXX methods in 
> RawAsyncTable/AsyncTable interface
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18951
>                 URL: https://issues.apache.org/jira/browse/HBASE-18951
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18951.patch
>
>
> As Optional is not supposed to be used as method parameters but we do not 
> want nullable parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to